Skip to content
Commit 6f1c6dc8 authored by David Edmundson's avatar David Edmundson
Browse files

Work round DBus property fetching bug

Summary:
property() works in a slightly different way to just calling Get().
It allocates the variant of the relevant type in advance in QObject
code, and then calls
the DBus code to populate it.

This fails for QByteArrayList, before it reaches DBus code.
I don't know why, but we need a wokraround in Solid anyway.

From a DBus traffic perspective this code is identical, we just avoid
going through Qt properties.

This shouldn't introduce any new bugs, as we already use GetAll
directly, if anything this brings it more
in line.

BUG: 345871

Test Plan:
Commented out the checkCache so that it always loads data.
Instead of failing, it now works.

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D4305
parent 49367aeb
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment