Skip to content
Commit c4a35f5e authored by David Edmundson's avatar David Edmundson
Browse files

Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

Summary:
See the end of QComboBox::initStyleOption

    if (d->container && d->container->isVisible())
        option->state |= QStyle::State_On;

The relevant breeze code reads:

        const bool hasFocus( enabled && ( state & (State_HasFocus |
State_Sunken ) ) );
        const bool sunken( state & (State_On|State_Sunken) );

So we still remain sunken in breeze, but we don't assume hasFocus, which
gives the background an incorrect colour.

CCBUG: 403153

Test Plan:
Ran testComboBox from Aleix
Debug inside Breeze QStyle + reading Qt code

Reviewers: broulik

Reviewed By: broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18284
parent 4f00b0ca
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment