Skip to content
Commit 4ae36ddd authored by David Edmundson's avatar David Edmundson
Browse files

Fix PowerDevil shortcuts migration

Summary:
5.11 -> 5.12 migrated shortcuts from kded5 to the correct component name
org_kde_powerdevil for good reasons
However, despite a kconfupdate script working correctly and moving the
old keys, kglobalaccel is running whilst we update and it syncs the old
values later. On future loads it detects the duplication and removes the
powerdevil entries.

This patch removes the old powermanagent entries in the kded5 component
at powerdevil startup which is at runtime where we can talk to
kglobalaccel, but before powerdevil has registered the new actions.

This should handle both users that haven't upgraded to 5.12 yet, as well
as users who hit the previous config script.

Ideally kconf_update needs to be patched to do migration at appropriate
times.

BUG: 389991
FIXED-IN: 5.12.2

Test Plan:
"broke" my config by putting in values in the old place with a custom shortcut for poweroff
Restarted kglobalaccel
Ran powerdevil
Shortucts worked
Cleanly quit kglobalaccel
Config stayed synced

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, fvogt, aacid, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10668
parent a7428cd8
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment