Skip to content
Commit 2ce60f4e authored by Konrad Materka's avatar Konrad Materka
Browse files

[applets/systemtray] Lazy initialize SystemTray model

Summary:
SystemTray model was created in constructor, delay initialization and
create it lazily.
The `SystemTray::appletAdded` signal is connected to both SystemTray's
model and `Container`. `Container` must be connected first, because it sets
some properties of newly added applet: `visible` to false and `parent`
to the root item (container). If `Container` is connected second, then
newly created applet ios added to the model and rendered, but immediately
after that `Container` changes visibility to false.

BUG: 420993

Test Plan:
1. Do not play anything (no Medial Player icon at all)
2. Run Gwenview
3. Check if Medial Player icon in hidden view is rendered correct.
Before change:
Sometimes icon is not rendered, looks like invisible or fully transparent.
After change:
Icon rendered correctly.
parent 220d3540
  • Developer

    @kmaterka

    This commit causes a significant regression for me: when plasma starts, my custom tray item visibility settings are ignored and the tray uses its default settings until I change a visibility setting and apply the changes. Fixing this is somewhat urgent considering that it's on the stable branch which will be tarred for release in a little over a week.

  • Author Developer

    I will fix that immediately!

  • Author Developer

    Fix in !23 (merged).

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment