Skip to content
Commit 1cb71a2c authored by Eike Hein's avatar Eike Hein
Browse files

Fix bad model hygiene in Positioner::move()

Summary:
Don't change the proxy maps prior to insert/remove transactions so
rowCount() at transaction start time matches the count passed into
the method. The old code hits an ASSERT in Qt 5.11 otherwise.

Care is taken not to emit dataChanged() in the middle of another
transaction.

Also cleaned up vestiges of caching lastRow(): This cache was
evicted all over the places but never actually filled anymore, so
maybe we don't need it.

BUG:396666

Reviewers: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14243
parent 6efda719
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment