Skip to content
Commit 229a5e2c authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇
Browse files

Signal player gone in "pagehide" not "beforeunload"

I don't recall if there was a particular reason for using *before* unload but this event is not emitted for iframes.
Using "pagehide" instead makes an iframe content script notice it's being destroyed (e.g. because of the overlay it was in being removed)
and correctly signals the player being gone. "unload" supposedly causes the browser trouble caching the page.
We did noticed a video in an overlay being removed but not when it was inside of an iframe.

Differential Revision: https://phabricator.kde.org/D28926
parent a39beb6c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment