Suggestion - newline ending after password to output
Summary: This is meant more as a question rather then actual code fix intention: I have a problem with `sudoedit` cmd line tool only accepting password from `ksshaskpass` if it is provided with newline in the end. Specifically in current state - calling: ``` EDITOR=kate SUDO_ASKPASS=/usr/bin/ksshaskpass sudoedit -A /etc/hosts ``` ...will result in a Ksshaskpass dialog and after entering the password the command just ends. But after applying this patch it starts working and kate is opened. I tried other graphical askpass programs, namely ssh-askpass, qt4-ssh-askpass, lxqt-ssh-askpass and gnome-ssh-askpass2 (gtk2). They all work nicely with sudoedit. My question is: Is it intentional that the password is not returned with newline? Should I ask sudoedit guys instead? Or is the problem elswhere, e.g. in KPasswordDialog (KF5 kwidgetaddons)? Thanks! PS: Please add reviewers as needed, I don't know the proper flow here, sorry :). Test Plan: Tested on sudoedit as well as git connecting to github with username and password. Reviewers: cfeck, davidedmundson Reviewed By: davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4775
parent
66ea9ec7
Please register or sign in to comment