Skip to content
Commit 4af9ea1e authored by David Edmundson's avatar David Edmundson
Browse files

Try getting the X keyboard grab multiple times

Summary:
Right now when the screen locker starts it tries to grab the keyboard on
X. This fails if any other application has grabbed the keyboard.

In these situations the screen simply doesn't lock which is a pretty
rubbish state.

This can't be realistically fixed properly on X, on wayland it's a
non-issue.

However, we can minimise the occasions when this occurs.

This patch emits a signal before locking and then tries the lack
multiple times. Clients can listen for this event and release their
keyboard grabs.

Test Plan:
Wrote relevant matching kwin patch to close effects
"sleep 5 ; loginctl lock-session" whilst a desktop effect was active
still locked the session

Reviewers: #plasma, #kwin, zzag

Reviewed By: #plasma, #kwin, zzag

Subscribers: zzag, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20804
parent e9f1b286
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment