Skip to content
Commit 2601fa10 authored by David Edmundson's avatar David Edmundson
Browse files

Fix crash in Screen Locker KCM on teardown

Summary:
As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
QWidget as a context item to QtQuick can crash. Especially as the
engine's context property gets deleted whilst deleting the parent item.

This patch reworks the code so that exposed properties go through a
proxy QObject.

CCBUG: 373628

Test Plan:
Pressing back whilst in the screenlocker KCM used to crash every time,
now it doesn't.

Also changed the wallpaper type, new settings appeared, I went from flat
image to a specific wallpaper, and then locked my screen.

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4535
parent 951b0b1f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment