Skip to content
Commit 3344e9bf authored by Igor Kushnir's avatar Igor Kushnir Committed by Aleix Pol Gonzalez
Browse files

Remove "text/x-diff" alias from supported MIME types

"text/x-diff" is an alias for "text/x-patch" MIME type. Therefore its
glob patterns are identical: "*.diff" and "*.patch". The downside of the
presence of this alias in the SupportedMimeTypes list is that
LanguageController must either match all filenames against duplicate
patterns (as it does now) or detect and remove these duplicate patterns,
which would entail unnecessary extra code and still some run-time work.

There are many "x-patch" uses in KDevelop code base, but this was the
only use of "x-diff". That is why I don't think this alias will be
missed by anyone.
parent 8a0e6ff9
Pipeline #30411 failed with stage
in 1 hour
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment