Fix handling ORDER BY part of queries
Summary: - new APIs - maintain relations between connections, queries and column infos - fix cloning queries with ORDER BY - update and add autotests FIXED-IN:3.2 BUG:392753 CCBUG:393705 Test Plan: Required: KEXI & KDb 3.2 (current master) Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views. Expected: works, no crashes Test 2: Try these on a standard Persons and Cars test: select id from cars order by owner; select id from cars order by owner, model, id; select id, model from cars order by 2, 1; Expected: works, no crash Reviewers: piggz Reviewed By: piggz Subscribers: Kexi-Devel-list Tags: #kdb Differential Revision: https://phabricator.kde.org/D12873
Showing
- autotests/CMakeLists.txt 3 additions, 0 deletionsautotests/CMakeLists.txt
- autotests/OrderByColumnTest.cpp 212 additions, 0 deletionsautotests/OrderByColumnTest.cpp
- autotests/OrderByColumnTest.h 46 additions, 0 deletionsautotests/OrderByColumnTest.h
- src/KDbNativeStatementBuilder.cpp 2 additions, 2 deletionssrc/KDbNativeStatementBuilder.cpp
- src/KDbOrderByColumn.cpp 87 additions, 28 deletionssrc/KDbOrderByColumn.cpp
- src/KDbOrderByColumn.h 40 additions, 13 deletionssrc/KDbOrderByColumn.h
- src/KDbQueryColumnInfo.cpp 17 additions, 28 deletionssrc/KDbQueryColumnInfo.cpp
- src/KDbQueryColumnInfo.h 25 additions, 1 deletionsrc/KDbQueryColumnInfo.h
- src/KDbQuerySchema.cpp 18 additions, 4 deletionssrc/KDbQuerySchema.cpp
- src/KDbQuerySchema_p.h 29 additions, 1 deletionsrc/KDbQuerySchema_p.h
Loading
Please register or sign in to comment