Skip to content
Commit a2adbe4a authored by Harald Sitter's avatar Harald Sitter 🐧
Browse files

refactor basic OS info to be set via config and fixate it for testing

Summary:
the basic OS info is decided at compile time, on top of that
influences whether lsbrelease and osrelease are even run, and also
acts as seed value for some other members.
this resulted in tests failing on freebsd because it would detect freebsd
as build platform and then skip all the advanced lookup tech and having
unexpected values.

fetchOSBasicInformation is now a dangling static and used to determine
the default constructed config value of the operating system.
this is now also forced to read Linux for the tests.

I've also changed all the QLatin1Strings in the function to QStringLiteral.
as I recall QL1S is only faster when not turning the object into a
full QString, so these values shouldn't be QL1S.

Test Plan: tests pass on linux still (and hopefully freebsd CI too)

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22328
parent bcec05d1
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment