Skip to content
Commit ff074f9b authored by Oliver Kellogg's avatar Oliver Kellogg
Browse files

https://scan.coverity.com/projects/3327 Coverity fixes listed by CID :

178695 Unchecked return value in umldoc.cpp
- In function loadUMLObjectsFromXMI1 loop over QDomNode, on handling
  type "Model", in nested for-loop of i over Uml::ModelType, if name is
  m_root[i]->name() then
  - define local UMLFolder *curRootSave saving m_pCurrentRoot;
  - if return value from loadFromXMI1(tempElement) is false then restore
    m_pCurrentRoot from curRootSave and return false.

268392 Logically dead code in diagram_utils.cpp
- In function importGraph loop over lines handling of associations, if
  after handling of swapObjects `error' is set then `assoc' is
  guaranteed to be null; ergo remove the if-statement testing assoc.

364156 Uninitialized pointer field in codeimport/phpimport.cpp
- In PHPIncludeFileVisitor constructor initialize members m_indent and
  m_dependencies.

364157 Dereference after null check in umllistview.cpp
- In functtion loadChildrenFromXMI switch (lvType) case
  UMLListViewItem::lvt_Attribute et al. with findItem(nID) returning
  null, in the code handling (lvType == lvt_InstanceAttribute) with
  umlObject->asUMLInstance() returning non null do not reassign to the
  existing variable umlObject. Instead, define local UMLObject* attrObj
  receiving the result from instance->findChildObjectById(nID).

364159 Uninitialized pointer field in codeimport/phpimport.cpp
- In class DebugLanguageParserHelper constructor, initialize member
  m_ast to null.
- Additional cosmetic changes in class DebugLanguageParserHelper:
  - Rename function setFeeded to setFed.
  - Rename function isFeeded to wasFed.

CCBUG: 340646
parent 33d00b62
Pipeline #106194 passed with stage
in 14 minutes and 54 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment