Skip to content
Commit 5b8d6193 authored by Konstantin Kharlamov's avatar Konstantin Kharlamov Committed by Noah Davis
Browse files

SpectacleCore: make class inheritance check more robust

Commit

    f410b081 "Rename Platform* to ImagePlatform*"

introduced a regression by making spectacle window visible at the
moment of making rectangular screenshot. That happened because the
check for inheritance was using a string instead of a dynamic/qobject
cast, so after the rename the fact the code broke went unnoticed.

Fix that by using qobject_cast() instead, so if rename ever happens
again the code would refuse to compile.

While at it, also add a point that the delay there isn't only because
of the crash but also because X11 compositors different from kwin may
require some time for effects to disappear before the shot can be
made.

BUG: 484652


(cherry picked from commit 73b88ab1)
parent 409b1a2a
Pipeline #653535 passed with stage
in 1 minute and 11 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment