Skip to content
Commit 0af560b3 authored by Martin Flöser's avatar Martin Flöser
Browse files

Introduce a KWin/Wayland image grabber

Summary:
This new ImageGrabber makes use of the new DBus interface introduced
with D3412 in KWin.

Taking a screen shot on Wayland is significantly different to how
screenshot taking on X11 works. No application is able to access a
window buffer or even able to figure out which window is at a given
mouse position.

Due to that the complete interaction needs to go through the compositor.
The only supported mode is thus window under cursor with click. There is
no other mode available. The idea is to keep the user always under
control of the screen shot taking - a security feature.

Full screen shot or screen region shot is currently not yet supported.

Explaining the dbus interaction: spectacle creates a pipe fd which gets
passed to the compositor through the dbus call. It starts to read from
the pipe in a dedicated thread (to keep gui thread responsive) with a
timeout of 30 sec. Spectacle doesn't know when the user clicks, so a
reasonable timeout is required.

In case the user cancels the selection or clicks a "non window"
spectacle cannot know that and will read an empty image from the pipe.

Reviewers: #plasma_on_wayland, bgupta

Subscribers: plasma-devel

Tags: #plasma_on_wayland

Differential Revision: https://phabricator.kde.org/D3413
parent f9df0dcc
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment