Skip to content
Commit 84998b1d authored by Jonah Brüchert's avatar Jonah Brüchert 🌳 Committed by Nicolas Fella
Browse files

Introduce new PhoneNumber class 

The PhoneNumber class is useful as an interface type, so the caller isn't required to pass in a specific phone number format.

This should also reduce the number of parsing / serializing operations, since the phone number is stored in a parsed representation instead of a string.
parent e09524a8
Hide whitespace changes
Inline Side-by-side
  • Kevin Kofler @kkofler

    mentioned in issue #33 (closed)

     ·

    mentioned in issue #33 (closed)

    Toggle commit list
  • Kevin Kofler @kkofler ·
    Developer

    This commit is the most likely cause of issue #33 (closed). It is not valid to assume that a phone number will be in any particular format. Austrian service SMS messages come with a text string such as StadtWien as the caller ID.

  • Kevin Kofler @kkofler ·
    Developer

    Looks like the existing merge request !78 (merged) should fix #33 (closed). Can you please merge that?

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment