Skip to content
Verified Commit 8bb5b1a5 authored by ivan tkachenko's avatar ivan tkachenko 🗯
Browse files

ScrollView: Stop clipping by default 

For two reasons.

1. This is already set by default on its contentItem Flickable in
QQuickScrollViewPrivate::ensureFlickable method. It won't apply to any
custom flickable is manually declared or assigned though, such as any
ListView or GridView, so this is not a very compelling reason. But...

2. No other/upstream style does this. Thus, it sets up a trap of false
expectations for developers. By implementing this "convenience helper"
here, we are potentially masking bugs in their layout (such as missing
clipping on ListView), and those bugs would surface on other styles,
should they fallback to Basic or switch to Material for some reason.
So, don't overdo this. Style implementation is not an appropriate place
to add non-standard unexpected features.
parent db5374f2
Hide whitespace changes
Inline Side-by-side
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment