Skip to content
Commit 2aaecb14 authored by Jakob Petsovits's avatar Jakob Petsovits
Browse files

kcmodule: Remove SuspendHybrid from BatteryCriticalAction options

We now have SleepMode::HybridSuspend, to be used with
PowerButtonAction::SuspendToRam. Let's not lock ourselves into
also providing a PowerButtonAction that achieves the same thing
but needs a separate code path.

The global config KCM did not support selecting "Hybrid Suspend"
as an option in Plasma 5. Only since two months ago, i.e. in
pre-alpha versions of Plasma 6, did I expose this to the UI
via commit dfab5705. In hindsight, this was not a good idea
because it makes removing PowerButtonAction::SuspendHybrid harder.

Another follow-up commit will deal with removing this enum value
altogether. But for now, let's stop the bleeding by not releasing
a version of Plasma (even alpha) where the UI allows selecting it
in the global config KCM. (Note that for the profiles KCM, usage
of PowerButtonAction::SuspendHybrid has already been migrated
to PowerButtonAction::SuspendToRam + SleepMode::HybridSuspend.)

We'll still want this option in the long run, let's spend some time
later on to figure out how to properly expose it to the user.
parent 4bd81b16
Pipeline #515769 passed with stage
in 1 minute and 29 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment