Skip to content
Verified Commit dd72824a authored by Alexander Lohnau's avatar Alexander Lohnau
Browse files

Port to KJsonUtils::readTranslatedString

parent 0870507d
  • Developer

    This commit broke building with non-master Frameworks, like the most recent release. It also seems to not have gone through review.

  • Author Developer

    This commit broke building with non-master Frameworks

    Unless we are right before branching/dependency freeze Plasma depends on framewoks master.

    It also seems to not have gone through review.

    It is a really trivial port though

  • Developer

    @alex is right; Plasma master implicitly depends on frameworks master, so there isn't a dependency problem here.

    No comment on the code as I'm not a part of this work.

  • I might be wrong but isn't KJsonUtils::readTranslatedString come with 5.88 ? So at least we need to increase min KF version for this change because right now plasma-workspace's min KF version is at 5.86 or at least adding a version check before using KJsonUtils

  • Author Developer

    So at least we need to increase min KF version for this change

    Then people will get mad because they need to update all frameworks (even like kdelibs4support)

    What @ahiemstra is complaining about is the build with non-master frameworks - but that is de-facto the policy we have as Nate pointed out.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment