PipeWire: Make sure thumbnails properly use dmabuf again
There were some changes in KWin that only enabled exchanging streams (thumbnails in our case) in case it's properly supported. We need to explicitly request it now, otherwise we get memfd which is much slower. (cherry picked from commit 5dfcc037)
-
Developer
@apol fails in Neon with:
01:54:54 /workspace/build/libtaskmanager/declarative/pipewiresourcestream.cpp: In function ‘spa_pod* buildFormat(spa_pod_builder*, spa_video_format, const std::vector<long unsigned int>&)’: 01:54:54 /workspace/build/libtaskmanager/declarative/pipewiresourcestream.cpp:143:70: error: ‘SPA_POD_PROP_FLAG_MANDATORY’ was not declared in this scope; did you mean ‘SPA_POD_PROP_FLAG_HARDWARE’? 01:54:54 143 | spa_pod_builder_prop(builder, SPA_FORMAT_VIDEO_modifier, SPA_POD_PROP_FLAG_MANDATORY | SPA_POD_PROP_FLAG_DONT_FIXATE); 01:54:54 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 01:54:54 | SPA_POD_PROP_FLAG_HARDWARE 01:54:54 /workspace/build/libtaskmanager/declarative/pipewiresourcestream.cpp:143:100: error: ‘SPA_POD_PROP_FLAG_DONT_FIXATE’ was not declared in this scope; did you mean ‘SPA_POD_PROP_FLAG_HINT_DICT’? 01:54:54 143 | spa_pod_builder_prop(builder, SPA_FORMAT_VIDEO_modifier, SPA_POD_PROP_FLAG_MANDATORY | SPA_POD_PROP_FLAG_DONT_FIXATE); 01:54:54 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 01:54:54 | SPA_POD_PROP_FLAG_HINT_DICT 01:54:54 make[4]: Entering directory '/workspace/build/obj-x86_64-linux-gnu' 01:54:54 /workspace/build/libtaskmanager/declarative/pipewiresourcestream.cpp:145:70: error: ‘SPA_POD_PROP_FLAG_MANDATORY’ was not declared in this scope; did you mean ‘SPA_POD_PROP_FLAG_HARDWARE’? 01:54:54 145 | spa_pod_builder_prop(builder, SPA_FORMAT_VIDEO_modifier, SPA_POD_PROP_FLAG_MANDATORY); 01:54:54 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 01:54:54 | SPA_POD_PROP_FLAG_HARDWARE
SPA_POD_PROP_FLAG_MANDATORY appears 1st in 0.3.29
SPA_POD_PROP_FLAG_DONT_FIXATE appears 1st in 0.3.33
Neon testing has 0.3.28 which plasma-workspace built with ok before this change.
EDIT: Unstable has 0.30.33, so building OK there
So this seems to bump the minimum pipewire dependency for 5.23 to 0.3.33
Is this ok to do at this stage post beta? If so, can we add the minimum dep in cmakelists?
-
Author Developer