Skip to content
Commit 1c573dc5 authored by David Edmundson's avatar David Edmundson
Browse files

libtaskmanager: Simplify taskmanager test

The taskmanager desktop entry test was written in a way that ran one iteration of the test in the main function, but to test variations ran iterations 2-5 inside a loop. 

The result was re-use of variables across different tests. This hit a bug because QProcess::terminate is non-blocking resulting in the test calling start on a running QProcess, which doesn't have the desired intention. 

By using a common code path for all iterations we can move some variables onto the stack simplifying the code and avoiding this issue. It also sets us up for a QTestData refactor.
parent 3b71f97c
Pipeline #519265 canceled with stage
in 16 minutes and 58 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment