Skip to content
Commit 408cca64 authored by Rahul Rameshbabu's avatar Rahul Rameshbabu Committed by Nicolas Fella
Browse files

Add support for openconnect_set_external_browser_callback introduced in... 


Add support for openconnect_set_external_browser_callback introduced in openconnect v9.0 (libopenconnect 5.8) using QDesktopServices

Default libopenconnect external browser callback leads to zombie processes that
cause plasma-nm flows to break under certain conditions related to the external
browser process. Delegate showing the login URI to QDesktopServices.

Signed-off-by: default avatarRahul Rameshbabu <sergeantsagara@protonmail.com>
parent 8001f597
Pipeline #289086 passed with stage
in 3 minutes and 5 seconds
Hide whitespace changes
Inline Side-by-side
  • Justin Zobel 🌎 @justinzobel ·
    Developer

    This commit introduced build failures on Fedora ARM64.

    /builddir/build/BUILD/plasma-nm-1886827/vpn/openconnect/openconnectauthworkerthread.cpp: In member function 'int OpenconnectAuthWorkerThread::openUri(openconnect_info*, const char*, void*)':
/builddir/build/BUILD/plasma-nm-1886827/vpn/openconnect/openconnectauthworkerthread.cpp:212:108: error: cannot convert 'std::nullptr_t' to 'va_list'

    Full log: https://download.copr.fedorainfracloud.org/results/@kdesig/kde-nightly/fedora-37-aarch64/05156807-plasma-nm/builder-live.log.gz

  • Rahul Rameshbabu @binaryeater ·
    Author Contributor

    What I really should have been doing is passing an empty va_list to avoid ABI breaks... I'll make an MR with the change. Would make sense adding aarch64 builds/regression runs to the project itself.

    Edited by Rahul Rameshbabu
  • Justin Zobel 🌎 @justinzobel ·
    Developer

    Thanks! I do Fedora builds nightly which include ARM so if something is amiss I'll make sure to leave a comment on the commit that introduced it where I can (not a developer so I just look at blame on Gitlab to see who changed a file. 😀)

  • Rahul Rameshbabu @binaryeater

    mentioned in merge request !199 (closed)

     ·

    mentioned in merge request !199 (closed)

    Toggle commit list
  • Rahul Rameshbabu @binaryeater ·
    Author Contributor

    I really appreciate it @justinzobel. I have opened !199 (closed) to resolve this hopefully.

  • Rahul Rameshbabu @binaryeater

    mentioned in merge request !200 (merged)

     ·

    mentioned in merge request !200 (merged)

    Toggle commit list
  • Rahul Rameshbabu @binaryeater ·
    Author Contributor

    I ended up going with !200 (merged) instead.

  • Rahul Rameshbabu @binaryeater ·
    Author Contributor

    I see Fedora nightly builds for AArch64 are passing now with !200 (merged).

    Full log: https://download.copr.fedorainfracloud.org/results/%40kdesig/kde-nightly/fedora-37-aarch64/05117159-plasma-nm/builder-live.log.gz

  • Justin Zobel 🌎 @justinzobel ·
    Developer

    Yeah they are, thanks!

  • Rahul Rameshbabu @binaryeater

    mentioned in commit 4654501e

     ·

    mentioned in commit 4654501e

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment