This commit completely breaks both appmenu manager and palette manager functionality for me; reverting this commit fixes both.

Thanks for letting me know. Still works for me and another tester. Can you send me a WAYLAND_DEBUG=1 log.

!40 (merged)

this also seems to crash konsole for me:

(gdb) bt
#0  0x00007f554ec1a174 in wl_proxy_get_version () from /lib64/libwayland-client.so.0
#1  0x00007f553d8bfef8 in org_kde_kwin_server_decoration_palette_manager_create (org_kde_kwin_server_decoration_palette_manager=0x0, surface=0x1e0a520)
    at /home/jblackquill/KDE/Build/plasma-integration/src/platformtheme/wayland-server-decoration-palette-client-protocol.h:109
#2  0x00007f553d8c01c3 in QtWayland::org_kde_kwin_server_decoration_palette_manager::create (this=0x1c5bcd0, surface=0x1e0a520)
    at /home/jblackquill/KDE/Build/plasma-integration/src/platformtheme/qwayland-server-decoration-palette.cpp:70
#3  0x00007f553d8b3c83 in KWaylandIntegration::installColorScheme (this=0x1c5bdd0, w=0x1cd6490)
    at /home/jblackquill/KDE/Source/plasma-integration/src/platformtheme/kwaylandintegration.cpp:159
#4  0x00007f553d8b37c6 in KWaylandIntegration::eventFilter (this=0x1c5bdd0, watched=0x1c38d10, event=0x7ffee01dfbb0)
    at /home/jblackquill/KDE/Source/plasma-integration/src/platformtheme/kwaylandintegration.cpp:99
#5  0x00007f55502f375e in QCoreApplicationPrivate::sendThroughApplicationEventFilters (event=<optimized out>, receiver=<optimized out>, this=<optimized out>)
    at /home/jblackquill/KDE/Source/Qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1172
#6  QCoreApplicationPrivate::sendThroughApplicationEventFilters (this=this@entry=0x1c38f10, receiver=receiver@entry=0x1c38d10, event=event@entry=0x7ffee01dfbb0)
    at /home/jblackquill/KDE/Source/Qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1157
#7  0x00007f5551055ac8 in QApplicationPrivate::notify_helper (this=0x1c38f10, receiver=0x1c38d10, e=0x7ffee01dfbb0)
    at /home/jblackquill/KDE/Source/Qt5/qtbase/src/widgets/kernel/qapplication.cpp:3603
#8  0x00007f55502f3afa in QCoreApplication::notifyInternal2 (receiver=0x1c38d10, event=0x7ffee01dfbb0)
    at /home/jblackquill/KDE/Source/Qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1064
#9  0x00007f5550818ba2 in QGuiApplicationPrivate::handlePaletteChanged (this=0x7ffee01dfbb0, className=0x0)
    at ../../include/QtCore/../../../../../Source/Qt5/qtbase/src/corelib/kernel/qcoreapplication.h:116
#10 QGuiApplicationPrivate::handlePaletteChanged (this=this@entry=0x1c38f10, className=className@entry=0x0)
    at /home/jblackquill/KDE/Source/Qt5/qtbase/src/gui/kernel/qguiapplication.cpp:3444
#11 0x00007f555105a4b9 in QApplicationPrivate::handlePaletteChanged (this=0x1c38f10, className=0x0) at /home/jblackquill/KDE/Source/Qt5/qtbase/src/widgets/kernel/qapplication.cpp:1368
#12 0x00007f555222935c in activateScheme (colorSchemePath=..., overrideAutoSwitch=true) at /home/jblackquill/KDE/Source/kconfigwidgets/src/kcolorschememanager.cpp:41
#13 0x00007f555222a818 in KColorSchemeManager::activateScheme (this=0x1c70f10, index=...) at /home/jblackquill/KDE/Source/kconfigwidgets/src/kcolorschememanager.cpp:223
#14 0x00007f55522299b1 in KColorSchemeManager::KColorSchemeManager (this=0x1c70f10, parent=0x1cc4fc0) at /home/jblackquill/KDE/Source/kconfigwidgets/src/kcolorschememanager.cpp:109
#15 0x00007f5552c593ad in AppColorSchemeChooser::AppColorSchemeChooser (this=0x1e72190, parent=0x1cc4fc0) at /home/jblackquill/KDE/Source/konsole/src/AppColorSchemeChooser.cpp:23
#16 0x00007f5552e8b9dc in Konsole::MainWindow::setupActions (this=0x1d043e0) at /home/jblackquill/KDE/Source/konsole/src/MainWindow.cpp:346
#17 0x00007f5552e89257 in Konsole::MainWindow::MainWindow (this=0x1d043e0, __in_chrg=<optimized out>, __vtt_parm=<optimized out>)
    at /home/jblackquill/KDE/Source/konsole/src/MainWindow.cpp:80
#18 0x00007f5552e7f03d in Konsole::Application::newMainWindow (this=0x7ffee01e0730) at /home/jblackquill/KDE/Source/konsole/src/Application.cpp:122
#19 0x00007f5552e80d3e in Konsole::Application::processWindowArgs (this=0x7ffee01e0730, createdNewMainWindow=@0x7ffee01e05ef: true)
    at /home/jblackquill/KDE/Source/konsole/src/Application.cpp:383
#20 0x00007f5552e7f510 in Konsole::Application::newInstance (this=0x7ffee01e0730) at /home/jblackquill/KDE/Source/konsole/src/Application.cpp:171
#21 0x000000000040571e in main (argc=1, argv=0x7ffee01e0ac8) at /home/jblackquill/KDE/Source/konsole/src/main.cpp:228