Skip to content
Commit b57bf61d authored by Andreas Bontozoglou's avatar Andreas Bontozoglou Committed by Méven Car
Browse files

RecentFiles kcm: whattoremember: Make the value visible in the UI match the value saved 

In this commit:

1. Setting the property `kcfg_property=kcfg_value` on the QGroupBox. This should force
   the KConfigDialogManager to use that to retrieve that value that needs to be stored.
2. Introducing RecentFilesKcm::whatToRememberWidgetChanged which figures out the correct
   value of "what-to-remember" and sets it under the property `kcfg_value` and triggers
   the Save/Reset buttons.
3. Linking the above slot to the `QAbstractButton::clicked` signals of the radio buttons

BUG: 397487
(cherry picked from commit 5f1b83a6)
parent 7ae09d82
Pipeline #476764 passed with stage
in 6 minutes and 23 seconds
Hide whitespace changes
Inline Side-by-side
  • Rik Mills @rikmills ·
    Developer

    This breaks the build of plasma-desktop with frameworks 5.102.0, which as per its release 5.27.x should guaranteed to be compatible with.

  • Andreas Bontozoglou @urban ·
    Author Contributor

    I was building on kf5 for back-porting but it seems that KCModule::setNeedsSave does not exist in v5.102.0 (but exists in kf5). I will attempt to use markAsChanged which does similar job.

    How would I test this? I am rebuilding everything on kf5 (which will take some time) and then planning to checkout kconfigwidgets:v5.102.0 and rebuild with --no-src - would that work as a test?

  • Méven Car @meven ·
    Developer

    This needs to be reverted then, I did wasn't conscient this implied of KF version bump.

    Edited by Méven Car
  • Méven Car @meven

    mentioned in commit 9f524a6e

     ·

    mentioned in commit 9f524a6e

    Toggle commit list
  • Méven Car @meven

    mentioned in merge request !1710 (closed)

     ·

    mentioned in merge request !1710 (closed)

    Toggle commit list
  • Méven Car @meven ·
    Developer

    How would I test this? I am rebuilding everything on kf5 (which will take some time) and then planning to checkout kconfigwidgets:v5.102.0 and rebuild with --no-src - would that work as a test?

    You will need to reset --no-src build kcmutils with v5.102.0 as well.

    Alternatively, we can revert it !1710 (closed).

  • Méven Car @meven ·
    Developer

    The regression should be fixed with !1711 (merged)

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment