Skip to content
Verified Commit 351e676f authored by Fushan Wen's avatar Fushan Wen
Browse files

taskmanager: Update rootIndex when visibility is changed 

When there are two grouped tasks named A and B, and the position
of B is swapped with A (by dragging B), user can still see old
items of A in the textual list of grouped tasks B.

This is because in the original binding expression, both visualParent
and itemIndex are not changed, so QML will not re-evaluate the
expression.

To only update rootIndex when `groupDialog.visible` is true,
`Binding.when` is used, and `Binding.RestoreNone` is to avoid
sudden changes in height.

BUG: 446108
parent 0d847a02
Pipeline #103910 passed with stage
in 2 minutes and 41 seconds
Hide whitespace changes
Inline Side-by-side
  • ivan tkachenko 🗯 @ratijas ·
    Developer

    @fusionfuture Can I kindly ask you to add a boilerplate comment when doing this QtQml magic?

    // Deliberately imported after QtQuick to avoid missing restoreMode property in Binding. Fix in Qt 6.
  • Fushan Wen @fusionfuture ·
    Author Developer

    Eh, it seems too long. What about // TODO: Remove in Qt 6?

  • ivan tkachenko 🗯 @ratijas ·
    Developer

    This is what Qt uses upstream, so it makes sense to just stick with it. I'm pushing it to master, alight?

    Edited by ivan tkachenko
  • Fushan Wen @fusionfuture ·
    Author Developer

    Fine

  • ivan tkachenko 🗯 @ratijas

    mentioned in commit 9cfd6141

     ·

    mentioned in commit 9cfd6141

    Toggle commit list
  • ivan tkachenko 🗯 @ratijas ·
    Developer

    Done: 9cfd6141

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment