Fix pimcommon CMake
The configuration file for pimcommon was actually missing KIOCore, and at the same time it worked by accident by linking QtNetwork, which wasn't a public link target. This change adds the KIOCore dependency where it belongs and fixes the link targets properly by adding the actual dependencies (Qt Core, Gui, Widgets, DBus). Qt Network is a private link target, so it is moved where it belongs. Reviewed and ack'ed by krop on IRC.
-
Developer
For anyone wondering:
/data/kde/inst/include/KF5/PimCommon/pimcommon # grep -I -h "#include" * | sort -u #include "abstractgenericplugin.h" #include <KActionMenu> #include <kconfigskeleton.h> #include <KCoreConfigSkeleton> #include <KIO/Job> #include <KPIMTextEdit/PlainTextEditor> #include <KPIMTextEdit/PlainTextEditorWidget> #include <KPIMTextEdit/RichTextEditor> #include <KPluginMetaData> #include <memory> #include "migratefileinfo.h" #include "pimcommon/autocorrection.h" #include "pimcommon_export.h" #include <pimcommon/pimcommon_export.h> #include <PimCommon/PluginUtil> #include "pimcommonsetting_base.h" #include <PimCommon/SpellCheckLineEdit> #include <qapplication.h> #include <QComboBox> #include <QCoreApplication> #include <QDebug> #include <QDialog> #include <QHash> #include <QLineEdit> #include <QListWidget> #include <QObject> #include <QPair> #include <QSet> #include <QString> #include <QStringList> #include <QStyledItemDelegate> #include <QtCore/QByteArray> #include <QtCore/QList> #include <QtCore/QMap> #include <QtCore/QObject> #include <QtCore/QString> #include <QtCore/QStringList> #include <QtCore/QVariant> #include <QtDBus/QtDBus> #include <QTextCursor> #include <QTreeWidget> #include <QTreeWidgetItem> #include <QUrl> #include <QValidator> #include <QVector> #include <QWidget>
Please register or sign in to comment