Fix mainshelltest (and as a side-effect docdata saving)
Try fixing mainshelltest: one more passes now QUrl is not automatically exposed to DBus so the DBus call would fail. Changed the parameter to QString instead so that DBus invocation works. mainshelltest: set QStandardPaths to test mode Parse command line flags with a single dash as a long option Unlike KCmdLineArgs QCommandLineParser treats options starting with a single minus as multiple short options by default. Previously okular -unique would fail with the following error: Unknown options: u, n, i, q, u, e. Also changed mainshelltest to use two dashes in case this behaviour should change in the future. mainshelltest failures have been reduced from 15 to 4 by this commit. Fix docdata saving and added a warning message if it fails If the ~/.local/okular/docdata directory didn't exist previously creating the docdata file would fail as there are missing paths. It seems that KStandardDirs used to create the okular/docdata directory automatically, with QStandardPaths we have to create it manually. mainshelltest is down to one failed test now Fix final test case in mainshelltest as we call QProcess::terminate the exit code will not be 0 REVIEW: 126192
parent
37d56231
Please register or sign in to comment