Skip to content
Commit 0b25a83c authored by Friso Smit's avatar Friso Smit Committed by Nate Graham
Browse files

Do continous scrolling when there is high resolution scroll

parent 30969b49
Pipeline #335105 passed with stage
in 7 minutes and 1 second
  • Developer

    @fwsmit "Do continous scrolling when there is high resolution scroll", where is the "when there is high resolution scroll" in this commit?

  • Author Contributor

    Good question. Previously the angleDelta().y() value could be accumulated in controlWheelAccumulatedDelta and every QWheelEvent::DefaultDeltasPerStep (150) ticks there would be a zoom step. Now it uses the raw delta value. On touchpads or other high resolution scroll devices this gives smaller steps than 150 (maybe just steps of 1?)

  • Developer

    So it means stepped scrolling is handled in steps of “150”, but it no longer aligns to the default zoom steps but just zooms by “150”? I think using the default zoom steps was somewhat sensible.

  • Author Contributor

    For mouse, users, yes. It now zooms by 150. For touchpad users it zooms in smaller steps. It does seem that I've gotten rid of the default zoom steps, like zoom to fit, etc.

    I think using the default zoom steps was somewhat sensible. This is not the best place to discuss, but I think each zoom step should be roughly similar in zoom factor. It might be reasonable to do some kind of rounding to get nice zoom% numbers in the interface.

    Again, it's better to discuss this on the MR this came from or somewhere in bugzilla.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment