Skip to content
Commit 58f33b03 authored by Vlad Zahorodnii's avatar Vlad Zahorodnii
Browse files

plugins/overview: Allow switching between modes using shortcuts while already active

Overview and Grid modes have shortcuts assigned to them. While they
provide a way to toggle the overview effect between on and off state, in
other words overview <-> off or grid <-> off, it's not possible to move
between the modes by pressing those shortcuts, e.g. off -> overview ->
grid -> overview -> grid -> ... -> off.

The culprit seems to be that EffectTogglableState has two "inactive"
states - Inactive and Stopped. It's counter-intuitive and needs a further
cleanup.

To make switching between overview modes work, this change makes
EffectTogglableState::toggle() toggle the state based on the Active state.
There's only one active state.

CCBUG: 481335


(cherry picked from commit fc92544c)
parent 87565910
Pipeline #609144 failed with stage
in 9 minutes and 9 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment