Skip to content
Commit 26dff99f authored by Xaver Hugl's avatar Xaver Hugl
Browse files

platforms/drm: explicit modifiers 

IN_FORMATS contains information about which buffer formats can be
scanned out with a given drm plane. Using these plane-specific
format+modifier combinations as well as explicit modifiers in
general can yield bandwidth and performance improvements,
especially in multi-gpu systems.
parent 19cc2210
Hide whitespace changes
Inline Side-by-side
  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    @zamundaaa - this commit causes my display port monitor to look like this.PXL_20210830_023850862

    Interestingly when I screenshot it looks perfectly normal. Screenshot_20210830_123730

    Thoughts?

  • Xaver Hugl @zamundaaa ·
    Author Developer

    What happens if you set the environment variable KWIN_DRM_NO_MODIFIERS to 1 for KWin?

  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    I tried setting that and it makes no difference.

  • Xaver Hugl @zamundaaa ·
    Author Developer

    Hmm, then nothing should've changed with this commit. What's the output of drm_info?

    Also make sure you have d6de38c1 / the latest git master.

  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    When i'm running latest master i suffer from the black screen bug that came about in commit 1be65e818c8759c12dfd7f731f142ef067b4c050

  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    drm_info.txt

  • Xaver Hugl @zamundaaa ·
    Author Developer

    Hmm. The screenshot being normal means that the buffer on the Intel GPU is fine, something just goes wrong when copying it over. drm_info says we're using XRGB8888 like usual though... And we're always using the same format on all GPUs atm.

    Is the drm_info output with this commit, or from an earlier revision? Having both would be good to compare them.

  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    My Bad from another revision. I'll make some for other revisions then :)

    this revision - 26dff99f drm_info-26dff99f7827be3dc52f13b2eddaabcd82e0671a.txt

    Edited by Carlos De Maine
  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    last working commit - 19cc2210 - drm_info-19cc22102c834aeadc9e1b68f32b7514aefaa769.txt

  • Xaver Hugl @zamundaaa ·
    Author Developer

    Aha - XRGB2101010 is the actual format form the current revision. That explains everything... With !1348 (merged) everything should work again then :)

  • Carlos De Maine 🎱 @carlosdem ·
    Developer

    1be65e81 - black external monitor bug - drm_info-1be65e818c8759c12dfd7f731f142ef067b4c050.txt

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment