Skip to content
Commit 1c521500 authored by Vlad Zahorodnii's avatar Vlad Zahorodnii
Browse files

x11: Fix shading with non-zero border

There was a geometry change that fixed mixing the next and current
geometries. While it did fix issues on wayland, it broke window shading
on x11 because of an obscure resize() call.

That obscure resize() had a side-effect that ensures m_clientGeometry
has the right value so the next time the window is unshaded,
implicitSize() will return a good value.

In order to make window size computation more robust, this change makes
X11Window compute the natural frame size based on cached size in
m_client, which shouldn't change when the window is shaded.

However, given how buggy window shading is and how difficult it is to
make it work right, I think that it's better to deprecate window shading
and remove it in some future release.

BUG: 450582
(cherry picked from commit 4790916f)
parent 3f110dff
Pipeline #206498 passed with stage
in 22 minutes and 15 seconds
  • Vlad Zahorodnii wrote: "However, given how buggy window shading is and how difficult it is to make it work right, I think that it's better to deprecate window shading and remove it in some future release."

    Please don't remove window shading. Many people, including me, use it for years now. Thank you for all your efforts with coding.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment