Skip to content
Commit e5ef8184 authored by Felix Ernst's avatar Felix Ernst 🇺🇦 Committed by Felix Ernst
Browse files

Fix file rating being unreadable in certain themes

Typically, a rating on a file is represented by five stars in a
row. If the first 3 stars are filled and the other 2 aren't, that
represents a 3/5 star rating.

When a theme only provides the filled stars (i.e. "rating") icon
but no unfilled stars (i.e. "rating-unrated") icon, KRatingPainter
would always paint all five stars as filled no matter if the actual
rating was 1/5 or 5/5 because the automatic fallback of the
"rating-unrated" icon is the "rating" icon as stated by the icon
theme spec.

This commit fixes this by having KRatingPainter use a generated
replacement "rating-unrated" icon (a de-saturated and grey-scaled
"rating" icon), if the theme does not provide a "rating-unrated"
icon already.

BUG: 339863
parent 808d2176
Pipeline #475548 passed with stage
in 5 minutes and 48 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment