mentioned in commit c17cd7a1

mentioned in merge request !10 (merged)

@ahmadsamir @mlaurent Did we have a discussion about committing the changes to apps and not only frameworks?

AFAIK, no; but I don't see why not though; the goal is to build KF to see if we can get apps building against Qt6, how well that works ...etc.

We could raise the question in the next KF6 meeting.

Right. "Pilot ports" of applications can be useful to properly test KF6. However some constraints of Frameworks don't apply to apps, e.g. we can use version-less targets there. OTOH some rules equally apply there, such as not regressing the 5 build (the unconditional commenting out in this change looks suspicious in that context for example).

My other concern is that KNS was made optional, simply because it was not ready for the Qt6 build. I have fixed all the depreactions and montel did the build system changes afterwards.

IMHO this is not how we should go about it. If we want to build an app against Qt6 we should make sure all its deps are ready.

I agree with @vkrause regarding the version less targets

The comment was fixed in other commits. So it's not a problem no ? "KNS was made optional" was is the problem ? In kf5 you can build against it.

Oh indeed, I didn't look at other commits, sorry. Seems like the commenting was just accidentally part of this commit, so no problem there :)

Yep it was just an error and I fixed it in commit after that.

The worry here is that we could forget to re-enable knewstuff for KF6/Qt6 (so this change could have waited until knewstuff changes are merged and it can be built against Qt6). :-)

knewstuff is not disable in qt6 it's optional so if we have knewstuff installed it will build against it.

Right, but distros might miss it? it's not a big deal, especially here, but it's something to keep in mind going forward, I think.