Skip to content
Commit 8283de28 authored by Harald Sitter's avatar Harald Sitter 🐧
Browse files

make kiologfilereader test actually do something

previously:
- it read from http which would error in the kjob but since
  the kiologreader class has no facilities to communicate errors this
  gets ignored
- it consturcted a !local! url from an http uri string resulting in kio
  constructing a file slave for http://localhost...
- it had a 100 second wait for no good reason
- it didn't do any verification of any sort
- all in all this test was a fancy sleep 100

new:
- replaced excess slot with lambda to compress test case to make it
  more readable in one go
- find fixture on-disk via QFINDTESTDATA
- make logfile read that
- connect to read lines and line-for-line compare them with the fixture
  (read via qtextstream)

i.e. this test now actually checks that the logfile class can read lines

REVIEW: 128328
parent e2f0ab79
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment