Skip to content
Verified Commit 4c38a1b4 authored by snooxx 💤's avatar snooxx 💤
Browse files

Remove duplicate 25x25 letter marker sprites from ksudoku_scrible.svg 

Investigating ksudoku_scrible.svg in Inkscape reveals a redundant color
swatch overlayed on top of its duplicate, and indeed a `<g>` labeled
`#g3571` shows up two times in the SVG code. Comparing both by removing
whitespace and sorting lines shows that there are no differences apart
from properties like `id="markers25_7"`, which are referenced by the
sprite rendering code.

Since the formatting and position of the first duplicate looks similar
to the 16x16 marker code, it is kept and the second duplicate is removed
instead. To keep cell marker functionality intact, the corresponding
`ids` are moved over.

Notes:
  - The `<rect>` sprites are only used to define size and position, the
  text/shape is taken from the actual cell marker letter sprites.
  - 41318869 in master (written long after this patch was first
  drafted) tried to deduplicate too, but broke cell markers due to
  removing the essential marker `ids`. Watch out when cherry-picking.

Test Plan:
Using the Scribble theme, start a 25x25 Sudoku game and check
that cell markers as well as all other graphical elements still work
fine.
parent 7ea6780e
Expand all Hide whitespace changes
Inline Side-by-side
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment