Skip to content
Commit 0bdaf2dc authored by Akarsh Simha's avatar Akarsh Simha
Browse files

Prevent unsafe connect by accepting slot in KSDssDownloader constructor

KSDssDownloader commits suicide, so code like:

KSDssDownloader *foo = new KSDssDownloader( ... );
connect( foo, ... );

has potential to fail.

N.B. The better and more correct fix would be to make the one-shot
use-case of KSDssDownloader a static method, just like the one-shot
QTimer. It can internally create a class instance and safely handle
its destruction.
parent 55a83c05
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment