Fix scale computation when fitting framebuffer to local view.
-
mentioned in commit 312c4250
-
In my opinion this commit was wrong and broke the logic of scaling, and should be reverted. The original behaviour of the
Scaling
button (before my changes with slider) was that, when button was off, then there was1:1
view. With button on, there wasFit to view
scaling.With my slider the change was that slider allow for continuous transition between these two states.
What @lcarlon did with this merge is that he broke the
1:1
view. Now the let position isFit to view
as it was original, but the right position fits to local height/width, whatever first best, lets call itFit to W/H
. I understand that @lcarlon maybe wanted this, but this is not how scaling work before. And I believe that some users maybe wished theFit to W/H
but it does not allow true1:1
view. I need it and in the version before this change theFit to W/H
was possible by manually positioning the slider. The true1:1
view is required when th remote is much larger (image multiple screen display via x11vnc) being scaled to small laptop screen. If you need to see the detail, you may need to go to1:1
andFit to W/H
will not provide sufficient zoom.Below is the image presenting both, pre-merge (my original contribution) and post-merge (@lcarlon change) behaviours. The magenta and green are remote and local views respectively. The remote is larger. I consider this commit as regression.