Fix block selection mode in a couple of cases
Summary: Make it possible to extend the selection when selecting text in column/block mode, by holding down Alt+Ctrl+Shift. Commit e5b74809 disabled text selection in apps running on the Alternate screen buffer, when they tell the terminal they're interested in Mouse Tracking events, unless only the Shift key is pressed; this accidentally prevented block selection mode from working in that case. Tweak the condition, to also allow block selection mode to work when Shift is pressed. Note that the selection can't be extended in programs while Mouse Tracking events are enabled. BUG: 331034 FIXED-IN: 18.08 Test Plan: - Open a new tab and `cat` some file to have some text on the screen: a - Select text with no modifier keys pressed b - Select some text, press and hold Shift and extend the selection c - Press and hold Alt+Ctrl, to select text in block mode, and while still pressing Alt+Ctrl, press Shift and extend the selection in block mode - Open some file in vim, with normal mode `:set mouse=`, and repeat a, b, c - Switch to visual mode in vim `:set mouse=a`: - Hold down Shift and select text - Hold down Shift+Alt+Ctrl and select text in column mode - Note that extending the selection doesn't work in vim visual mode (i.e. after the app indicates it's interested in Mouse Tracking events) Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, anthonyfieroni, konsole-devel, #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D13356
parent
d6b3cfdc
Please register or sign in to comment