Skip to content
Commit d747635c authored by Luca Carlon's avatar Luca Carlon Committed by Matan Ziv-Av
Browse files

Fix position and size of the underline 

When rendering underlined text in hidpi, the result may be wrong: position
of the underline may be wrong, invisible or with incorrect size.

The patch draws the line using floating point precision and changes the y coord
of the line to respect the Qt coordinate system specs.

CCBUG: 373232
parent 87c895cf
Pipeline #387687 failed with stage
in 3 minutes and 3 seconds
Hide whitespace changes
Inline Side-by-side
  • Nate Graham @ngraham ·
    Developer

    @lcarlon @matan Do you think this is safe to cherry-pick to the stable branch?

  • Matan Ziv-Av @matan ·
    Developer

    Yes, but probably 87c895cf from !846 (merged) first.

  • Luca Carlon @lcarlon ·
    Author Contributor

    I sent a total of 4 MR, and unfortunately all 4 are a bit conflicting with each other, I'm sorry. This one assumes !846 (merged) is present, which fixes the missing line spacing. So be careful with the order.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment