Skip to content
Commit 304305f7 authored by Waqar Ahmed's avatar Waqar Ahmed Committed by Tomaz Canabrava
Browse files

Dont resize screenLines all the time

parent fbf48758
  • Konsole::Screen::clearImage > std::fill is occasionally (after a few minutes of use) segfaulting after a recent commit (possibly not this commit). See https://bugs.kde.org/show_bug.cgi?id=445550 .

    Edited by Henry Heino
  • mentioned in merge request !516 (merged)

    Toggle commit list
  • @personalizedrefrigerator Can you maybe share what you were doing before it crashes? I have been using this change for a while without any crashes so it must be something that I don't do.

  • It seems somewhat random... I was using Vim to write a LaTeX document most of the times that it crashed.

    See the reproduction steps associated with the bug for what I was (generally) doing.

  • Please note that this could be the result of something else that was merged today. I can try to find the specific commit (but it might take me a few days to get to this).

    Edit: If I open vim, enter edit mode, and hold down enter, I can quickly reproduce the crash. My .vimrc can be found here: https://github.com/personalizedrefrigerator/dotfiles/blob/main/.vimrc

    Edit 2: I am most suspicious of these lines in my .vimrc:

    " Change cursor when entering insert mode
    " Ref: https://stackoverflow.com/questions/6488683/how-do-i-change-the-cursor-between-normal-and-insert-modes-in-vim
    let &t_SI = "\e[6 q"
    let &t_EI = "\e[2 q"
    Edited by Henry Heino
  • Okay, found another issue that is related (moveImage was broken). Fixing that, I think that will fix the crash too.

  • @personalizedrefrigerator please try with latest master, see if you can still make it crash. Also, vim :help was broken, so that should be working correctly too now. Thanks a lot for bringing this up so early!

  • I haven't been able to reproduce this on master — I think it's fixed!

  • I'm getting crashes too with yesterday's git master in vim, when hitting the delete or backspace key at the end of a line while writing a commit message. Will try again with today's git master.

  • Still seeing it with today's git master. :(

  • @ngraham I tried reproducing it but seems to be working for me. Do you have more detailed repro instructions maybe?

  • I don't sorry. Just what I mentioned already. I couldn't find a 100% consistent reproducer.

    That said, it's stopped happening. Maybe it got fixed with some of the recent changes yesterday. and the day before. I'll keep an eye on this.

  • I kept trying to reproduce this today at work, but haven't been able to.

    In any case, will be happy to know if you reproduce it again. We need our Konsole to be invincible ;)

    Edited by Waqar Ahmed
  • Indeed!

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment