Skip to content
Commit 16b3919f authored by Albert Astals Cid's avatar Albert Astals Cid
Browse files

Fix heap-use-after-free in Part destructor

Tear down the ViewManager on the Part destructor instead of letting Qt destroy the child objects itself.

This way we control the sequence more and make sure we don't end up using memory that was already deleted. Fixes the ASAN detected problem in https://build.kde.org/job/konsole%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/testReport/%28root%29/TestSuite/PartTest/

Neither ASAN nor valgrind complain anymore when running PartTest.

REVIEW: 125366
(cherry picked from commit ace53ef4)
parent 05d2328d
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment