Fix compilation with Qt 5.12 and Qt 5.13
Despite Qt 5.12 being the minimum required Qt version, the following functions introduced in Qt 5.14 were used: - QComboBox::textActivated (in settings/konqhtml/appearance.cpp) - downloadFileName, downloadDirectory, setDownloadFileName, setDownloadDirectory in QWebEngineDownloadItem Don't use QComboBox::textActivated Use QWebEngineDownloadItem::path and QWebEngineDownloadItem::setPath with Qt 5.13
parent
900079a5
-
mentioned in commit 818eb665
-
Issues still persist, compilation now fails at:
konqueror/plugins/searchbar/searchbar.cpp:74:40: error: ‘textActivated’ is not a member of ‘QComboBox’ konqueror/webenginepart/src/webenginewalletprivate.cpp:185:55: error: ‘class QLatin1String’ has no member named ‘arg’ konqueror/webenginepart/src/webenginepartdownloadmanager.cpp:151:53: error: ‘class QWebEngineDownloadItem’ has no member named ‘suggestedFileName’ konqueror/webenginepart/src/webenginepartdownloadmanager.cpp:258:121: error: ‘class QWebEngineDownloadItem’ has no member named ‘downloadFileName’ -
-
I created merge request !34 (merged) for this issue. Please, could you try to compile it, so I'm sure we won't miss other problems? Unfortunately, I don't have a system with Qt 5.12 to test on.
-