Skip to content
Commit d4dd5875 authored by Martin Klapetek's avatar Martin Klapetek
Browse files

Add unit tests for KNotification and fix issues uncovered by them

Adds basic set of unit tests including fake notifications server.
This helped uncover and fix these issues:

* Calling close() on KNotification that was not "sent" would not emit
closed() and would not delete it
* Closing a notification can delete the KNotification object prematurely
* Invoking an action leads to unnecessary dbus roundtrip
* Invoking an action would fail to properly close and delete the
KNotification object
* Start assigning the ids at 0 rather than 1 with -1 still being
invalid.

REVIEW: 127398
parent b6238c84
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment