Skip to content
Commit 34d8033c authored by Alexander Lohnau's avatar Alexander Lohnau
Browse files

QuickItemsModel: Remve isLoadingData property 

Instead, use the property from the engine directly
parent e895e8c7
Hide whitespace changes
Inline Side-by-side
  • Yifan Zhu @fanzhuyifan ·
    Developer

    @alex there still seems to be a dangling onIsLoadingDataChanged here: https://invent.kde.org/frameworks/knewstuff/-/blob/master/src/qtquick/qml/Page.qml?ref_type=heads#L76

    I am not sure how that should be changed. Could you fix that? Thanks!

    PS: We would also need to call the signals directly instead of the signal handler (https://bugreports.qt.io/browse/QTBUG-120573)

  • Alexander Lohnau @alex ·
    Author Developer

    I spent some time investigating this and it is only used by the knewstuff-dialog tool

  • Alexander Lohnau @alex ·
    Author Developer

    Oh man, this is only a really edge case and lots of stuff before in the callstack is broken anyway :(

  • Yifan Zhu @fanzhuyifan ·
    Developer

    Oh man, this is only a really edge case and lots of stuff before in the callstack is broken anyway

    I see. I only came across this because I was trying to replace all calls to signal handlers with calls to signals (https://bugreports.qt.io/browse/QTBUG-120573). So what do you think is the best way to proceed? If lots of stuff was broken anyway I am happy to leave that dangling call to the signal handler as it is.

  • Alexander Lohnau @alex ·
    Author Developer

    I have already started working on fixing the parts which could be useful

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment