Skip to content
Commit 24ce1327 authored by Friedrich W. H. Kossebau's avatar Friedrich W. H. Kossebau Committed by Ben Cooksley
Browse files

Add explicit moc includes to sources for moc-covered headers

* speeds up incremental builds as changes to a header will not always
  need the full mocs_compilation.cpp for all the target's headers rebuild,
  while having a moc file sourced into a source file only adds minor
  extra costs, due to small own code and the used headers usually
  already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
  resulting in those quickly processed, while the minor extra cost of the
  sourced moc files does not outweigh that in summary.
  Measured times actually improved by some percent points.
  (ideally CMake would just skip empty mocs_compilation.cpp & its object
  file one day)
* enables compiler to see all methods of a class in same compilation unit
  to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
  moc code being sourced into the cpp file there definitions can be ensured
  and often are already for the needs of the normal class methods

moc includes generated with script from sdk/kde-dev-scripts!24 + some manual fine-tuning of newlines.

Checked completeness by this running in the toplevel build dir giving `0`:  
`find . -name mocs_compilation.cpp -exec cat {} \; | grep "#include" | wc -l`
parent b6b8d42b
Pipeline #429198 passed with stage
in 3 minutes and 13 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment