Skip to content
Verified Commit 9c068e9c authored by Daniel Vrátil's avatar Daniel Vrátil 🤖
Browse files

Fix use-after-free in ConfigureAppearancePage

KLocalizedString().untranslatedText().constData() returns pointer
to data of a temporary QString that gets destroyed at the end of
the statement. Accessing the data in the pointer later accesses
a free'd memory. ASAN has caught this as heap-use-after-free.

I don't see a reason to use constData(), especially since we only
use it to construct a QString from it later on, so we can just use
the QString right away.
parent ac2c05df
Pipeline #573294 passed with stage
in 12 minutes and 38 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment