Skip to content
Commit 5171464e authored by Raphael Kubo da Costa's avatar Raphael Kubo da Costa
Browse files

unifiedmailboxagent: Stop using std::optional.

Summary:
This reverts most of commits 39cbfe72 ("I can haz
std::experimental::optional!") and b44642b4 ("Rename "exp" namespace to
"stdx" to avoid conflict with exp()"), as well as other commits fixing the
build. Follow-up coding style adjustments (done mostly in commit c8e59b1a
"GIT_SILENT: coding style") have not been reverted though.

std::optional support is only officially supported in C++17 or later, but we
were still requiring only C++14 to build unifiedmailboxagent. Switching to
C++17 in the Applications/18.12 branch requires a change to akonadi that is
only available in its master branch (ceeb4f3a, "Disable std::auto_ptr checks
in Item in C++17"), and in any case C++17 support is fairly recent
everywhere so we can just wait a bit longer before depending on it.

The discussion in https://phabricator.kde.org/D17606 is also relevant.

Test Plan: Built all code and unit tests, the same tests fail with and without this patch.

Reviewers: dvratil, #freebsd

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D17917
parent 737ad3bb
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment