Refactor of OverlaySheet based off Popup
Base OverlaySheet on Popup, making ti behave in a way more similar to them.
Two small changes are needed in code using it:
sheetOpen -> should just be visible now
contentItem: cannot be assigned, implementations should just be:
OverlaySheet {
ColumnLayout {...}
}
-
-
What do we do with this? https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/Page.qml#L186
-
🗯 @ratijasDeveloperidk why it even has to be there. Popup could (and should!) handle the Back button on its own. so, i'd say, kill it with fire
-
🗯 @ratijasDeveloperi guess the signal itself is fine. but the whole signal handler there is just to close OverlaySheet items, which were not regular Dialogs back then, so couldn't intercept focus and Beck button events.
-