Skip to content
Commit 24ca2595 authored by David Edmundson's avatar David Edmundson
Browse files

Run clang-format

If you want git blame to ignore formatting revisions run:
git config blame.ignoreRevsFile .git-blame-ignore-revs
parent 485ec27d
  • @davidedmundson looks like bsd is a little oversensitive about the include orders , it wants

    #include <sys/types.h>
    #include <sys/sysctl.h>

    not

    #include <sys/sysctl.h>
    #include <sys/types.h>

    because u_int and some other types defined in types.h and it used in sysctl.h and it causes compile break on bsd systems.

  • This is now resolved.

  • This is why // clang-format off exists. sys/types.h is one of those bugbears where BSDtly-folks feel it should be included explicitly, not implicitly, but that feeling is rather inconsistent, see e.g. this comment in unistd.h:

    #include <sys/types.h>                  /* XXX adds too much pollution. */

    I think I'll kick that hornet's nest over on a FreeBSD list :)

  • mentioned in merge request frameworks/kio!549 (merged)

    Toggle commit list
  • Or leave an empty line before or after it, then clang format won't change its order.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment