Run clang-format
If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
parent
485ec27d
-
Developer
@davidedmundson looks like bsd is a little oversensitive about the include orders , it wants
#include <sys/types.h> #include <sys/sysctl.h>
not
#include <sys/sysctl.h> #include <sys/types.h>
because u_int and some other types defined in types.h and it used in sysctl.h and it causes compile break on bsd systems.
-
Author Developer
This is now resolved.
-
Developer
This is why
// clang-format off
exists.sys/types.h
is one of those bugbears where BSDtly-folks feel it should be included explicitly, not implicitly, but that feeling is rather inconsistent, see e.g. this comment inunistd.h
:#include <sys/types.h> /* XXX adds too much pollution. */
I think I'll kick that hornet's nest over on a FreeBSD list :)
-
mentioned in merge request frameworks/kio!549 (merged)
-
Developer
Or leave an empty line before or after it, then clang format won't change its order.
Please register or sign in to comment