Skip to content
Commit 296c528b authored by Tushar Maheshwari's avatar Tushar Maheshwari Committed by Albert Astals Cid
Browse files

Fix KHMThemeFactory leaks and KHMTheme const-correctness

- Replace allocation using `new KHMTheme` in `KHMThemeFactory::doTheme` and `KHMThemeFactory::buildTheme` (rename to `getTheme`).
- Add `const` to `KHMTheme` and `KHMThemeFactory` member functions not modifying data.
- Fix `const` usage in callers of `KHMThemeFactory::getTheme`.
- Miscellaneous:
  - syntax changes for iteration.
  - QString comparison using operator==.
  - Move local variable declaration close to first use.

Testing:
- Tested patch with local build: themes are listed and applied successfully.
parent 0a9af726
Pipeline #177386 passed with stage
in 1 minute and 3 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment